Edit item – ProjectTasks

ContentType: ContentType.ProjectTask Item: gov-8a

Title *

CreatedAt

2026-09-30T15:26:28.7453347+00:00

Author

claude-code

TaskNumber *

ProjectCode *

TaskTitle *

AssigneeSku

DueDate

EstimateHours

Status *

Body

Role: test impact scout (read-only). The change: AutoGenesisToolInvoker, BuildDivisionToolInvoker, ExtractSkillToolInvoker and SelfReviewProposalRouter stop naming Engineering as the site their ApprovalRequest parks on; each reads a declared task list instead (Workflow TaskListSite/TaskListTitle already exists, commit 3cb8c96). Deliver in TaskOutcome: every test that asserts Department=Engineering or the Engineering/ApprovalRequests path for these four, as file:line plus the exact assertion, and which of the four has a part (Tool, Workflow) in reach to carry the attribute.

Outcome (spice-impact-scout, 2026-09-30): GOV.8a test impact (read-only). Scope: AutoGenesisToolInvoker, BuildDivisionToolInvoker, ExtractSkillToolInvoker, SelfReviewProposalRouter stop naming Engineering as the park site.

HARD BREAK (asserts the literal today):
- SelfReviewProposalRouterTests.cs:71 Assert.Equal("Engineering", (string?)op.Attribute("Department")) in Self_review_completion_synthesizes_addlistitem_against_engineering_approvals (line 56). Conditional: RequestFor() (line 156) builds PhaseRequest positionally with 5 args so WorkflowId is null; if the router follows the FinalDeltaApplyListener pattern (wf?.TaskListSite ?? "Engineering") this line stays green and proves nothing about the new path -> SAFE-BUT-VACUOUS if default stays Engineering, WILL-BREAK if the default flips to Compliance (GOV.8 parent evidence floats that). Fix: add a test passing WorkflowId="Workflow.SelfReview" + a StubParts Workflow carrying TaskListSite, or the change ships untested.
- BuildDivisionToolInvokerTests.cs:134 storage.Enumerate("Engineering", "ApprovalRequests") in Parked_division_round_trips_to_the_served_ApprovalRequests_list (line 119). Same conditional logic - WILL-BREAK only if BuildDivisionToolInvoker's resolved site stops defaulting to Engineering.

COMPILE-BREAK RISK (positional construction, not assertions):
- SelfReviewProposalRouter ctor has no IPartLibrary param; tests construct it new SelfReviewProposalRouter(applier, NullLogger...) at lines 35, 47, 59. Adding IPartLibrary to resolve Workflow.SelfReview breaks all three unless trailing-optional (IPartLibrary? parts = null), the AutoGenesis dmn/settings precedent already in that class.
- ExtractSkillToolInvoker.BuildApprovalDelta(parkKey, skillId, sourcePipeline, addSkillDelta) called positionally (4 args) at SkillLibraryExtractSkillTests.cs:297. Adding a site param breaks this call unless trailing-defaulted.
- BuildDivisionToolInvoker.BuildParkDelta(parkKey, title, subject, reason, inner, issuer) (6-arg static) called from RequestSiteToolInvoker.cs:54 (non-test, but breaks the test build if the signature changes without a default).
- RequestSiteToolInvoker.cs:75-76 embeds BuildDivisionToolInvoker.Site directly in an operator-facing message string ("parked at /sites/{Site}/Lists/..."). If Site stops being a readable const, this fails to compile; if it changes value, the message text must track it. Checked RequestSiteTests.cs: no Engineering/Site assertion there - SAFE, but the source dependency is real.

SAFE (confirmed, would mislead if 'fixed'):
- AutoGenesisToolInvokerTests.cs:156-159 comment says 'AddListItem into Engineering/ApprovalRequests' but the actual assertion only checks Attribute("List")=="ApprovalRequests", never Department - SAFE, comment is stale.
- AutoGenesisToolInvokerTests StubEnumerator.Enumerate(siteName, listName) (lines 82-87) ignores siteName entirely, filtering only on listName. So Open_row_with_a_reject_verdict_is_not_overwritten and Owned_status_row_is_not_overwritten (lines 246, 258) pass regardless of what Site resolves to - SAFE BUT BLIND to a real hazard: AutoGenesisToolInvoker.Site is triple-duty (park Department at BuildParkDelta:413, the R8 park-guard READ site at ReadExistingRow's enumerator.Enumerate(Site,...):242 and LoadLinkedVerdicts(enumerator, Site, ...):253, and ResolveContext(Department: Site) feeding the IdleCap/WorkCron settings at 300/305). If only the write path follows the new site while reads stay on Site's old resolution (or vice versa), R8 would read Engineering while writing Compliance and re-park over a human-owned row - the stubbed tests cannot catch that divergence. Recommend the resolved site feed both the read (242/253) and write (413) call sites identically, and leave the settings ResolveContext keyed on whatever Scope.AutoGenesis already uses (don't move it incidentally).
- SkillLibraryExtractSkillTests.cs:323-327 Assert.Equal("Engineering", dept) in ResolveDepartment_prefers_the_explicit_arg - this is the Skill-binding target (AddSkillBinding/department= arg), unrelated to the ApprovalRequest park site. SAFE, do not touch.
- SelfReviewProposalRouterTests.cs:107-121 Live_manifest_declares_engineering_approvalrequests_list pins that EngineeringPortal/ApprovalRequests exists in the manifest - stays true (the site isn't being deleted) but becomes the wrong pin once SelfReview's park moves; add a sibling assertion for whatever site Workflow.SelfReview's TaskListSite ends up naming.
- SkillLibraryExtractSkillTests.cs BuildApprovalDelta_parks_an_open_ApprovalRequest_carrying_the_AddSkill_delta (lines 290-314) never asserts the Department attribute at all despite ExtractSkillToolInvoker.cs:337 hardcoding Department="Engineering" - SAFE, no test regression from changing that literal, but also no test coverage of the new value; consider adding one.

WHICH OF THE FOUR HAS A PART IN REACH (verified against SAF-Parts.xsd:1314-1317 - TaskListSite/TaskListTitle are declared ONLY on WorkflowType, not ToolType):
- SelfReviewProposalRouter: YES, cleanly in reach. It already implements IPhaseCompletionListener.OnPhaseCompletedAsync(PhaseResult, PhaseRequest, ct) - the exact signature FinalDeltaApplyListener uses, and PhaseRequest already carries WorkflowId (IPhaseOrchestrator.cs:44, added for GOV.8). Workflow.SelfReview exists (Parts.xml:3280, single Phase.SelfReview step). Needs: inject IPartLibrary (trailing-optional ctor param), resolve via request.WorkflowId like FinalDeltaApplyListener.cs:73-76, and Workflow.SelfReview would need a TaskListSite/TaskListTitle attribute added if the desk should differ from the Engineering fallback. Lowest-risk, most reusable of the four - literally the same pattern GOV.8 just proved.
- BuildDivisionToolInvoker (Tool.BuildDivision): adjacent, not owned. Workflow.GenesisBuildDivision already declares TaskListSite="Compliance" TaskListTitle="ApprovalRequests" (Parts.xml:2774) but Tool.BuildDivision is the deterministic direct-chat path explicitly separate from that 3-phase workflow (see the invoker's own doc comment) - it is never invoked as a step of Workflow.GenesisBuildDivision and receives no WorkflowId. Wiring it to that Workflow's attribute would require a new, hand-picked lookup (_parts.Of<Workflow>() by a hardcoded Workflow.GenesisBuildDivision id), which is a judgment call, not a mechanical reuse.
- AutoGenesisToolInvoker (Tool.AutoGenesis): no Workflow in reach (invoked directly from a Schedule/CrewWork run, not a Workflow step). It already has the zero-new-seam alternative: ISettingsResolver + Scope.AutoGenesis are already injected and used for SettingIdleBornCap/SettingWorkCron (lines 63-64, 299-305) - a third SettingParkSite/SettingParkList pair is the path of least resistance, not a Workflow attribute.
- ExtractSkillToolInvoker (Tool.ExtractSkill): nothing in reach. No Workflow, no ISettingsResolver currently injected, and Tool (the part kind it is) carries no TaskListSite/TaskListTitle attribute in the XSD. Would need either a new ISettingsResolver injection (mirroring AutoGenesis) or an XSD-level addition of TaskListSite/TaskListTitle to ToolType - the only one of the four requiring an XSD change if a per-tool-declared site is wanted.

AssignedTo

Parent task

PercentComplete

Comments

Predecessors

Hold Ctrl (or Cmd) to select multiple.

PMO.4
PMO.3
CTX.5
CTX.4
CTX.3
CTX.2
CTX.1
GOV.16
TPL.36
GOV.15
GEN.5
GEN.4
GEN.3
GEN.2
GEN.1
INFRA.8
INFRA.7
INFRA.6
INFRA.5
INFRA.4
INFRA.3
INFRA.2
INFRA.1
PMO.2
TPL.35
HARNESS.20
PMO.1
INTAKE.14
STAFF.9
STAFF.8
GOV.14
GOV.13
STAFF.7
STAFF.6
HARNESS.19
INTAKE.13
STAFF.5
STAFF.4
STAFF.3
STAFF.2
STAFF.1
INTAKE.12
INTAKE.11
INTAKE.10
INTAKE.9
INTAKE.8
INTAKE.7
INTAKE.5
INTAKE.4
INTAKE.3
INTAKE.2
INTAKE.1
INTAKE.6
TPL.31
TPL.27
TPL.25
TPL.24
TPL.23
TPL.22
TPL.18
TPL.17
HARNESS.18
TPL.16
TPL.15
TPL.14
HARNESS.17
BRAINSTORM.29
SPWAY.30
BRAINSTORM.28d
BRAINSTORM.28b
BRAINSTORM.28a
BRAINSTORM.28c
BRAINSTORM.28
BRAINSTORM.23
BRAINSTORM.22
BRAINSTORM.18
BRAINSTORM.17
BRAINSTORM.16
BRAINSTORM.15
BRAINSTORM.14
BRAINSTORM.13
BRAINSTORM.12
BRAINSTORM.11
STUDIOS.6
BRAINSTORM.10
BRAINSTORM.9
BRAINSTORM.5b
BRAINSTORM.4c
BRAINSTORM.4b
BRAINSTORM.4
STUDIOS.5
STUDIOS.4
STUDIOS.3
STUDIOS.2
STUDIOS.1
BRAINSTORM.8
BRAINSTORM.7
BRAINSTORM.6
BRAINSTORM.5
BRAINSTORM.3
BRAINSTORM.2
BRAINSTORM.1
GOV.12f
GOV.12e
GOV.12d
GOV.12c
GOV.12b
GOV.12a
GOV.12
BRIDGE.15
BRIDGE.15a
GOV.10
GOV.9
GOV.9a
GOV.5b
GOV.5a
GOV.11
GOV.8
SPWAY.13c-c
SPWAY.13c-b
SPWAY.13c-a
SPWAY.13c
GOV.3-job-1
GOV.7
GOV.6
GOV.5
GOV.4
GOV.3
GOV.2
GOV.1
SPWAY.8i
BRIDGE.13b
BRIDGE.3c
BRIDGE.3b
BRIDGE.5a
BRIDGE.3a
BRIDGE.11b
BRIDGE.11a
BRIDGE.8a
SPWAY.6c-JobLevels
SPWAY.6c-Jurisdictions
SPWAY.6c-Industries
SPWAY.6c-BusinessProcesses
SPWAY.6c-ItPractices
SPWAY.6c-AiTopics
SPWAY.6c
BRIDGE.14
SPWAY.8h
BRIDGE.13
BRIDGE.12
BRIDGE.11
BRIDGE.10
BRIDGE.9
BRIDGE.8
BRIDGE.7
BRIDGE.6
BRIDGE.5
BRIDGE.4
BRIDGE.3
BRIDGE.2
BRIDGE.1
BRIDGE.0c
BRIDGE.0b
BRIDGE.0
SPWAY.15d
SPWAY.15c
SPWAY.15b
SPWAY.16
SPWAY.14b
SPWAY.12c-6
SPWAY.15a
SPWAY.15
SPWAY.14
SPWAY.12c-5
SPWAY.12c-4a
SPWAY.8g
SPWAY.8e
SPWAY.13b
SPWAY.13a
SPWAY.13
SPWAY.12c-4
SPWAY.12c-1
SPWAY.12c-3
SPWAY.12c-2
SPWAY.2g
SPWAY.2f
SPWAY.12d
SPWAY.12c
SPWAY.12b
SPWAY.11e
SPWAY.12
SPWAY.11d
SPWAY.11c
SPWAY.12a
SPWAY.11b
SPWAY.11a
SPWAY.11
SPWAY.2e
SPWAY.10j
SPWAY.8d
SPWAY.7d
SPWAY.10i
SPWAY.10h
SPWAY.10g
SPWAY.10f
SPWAY.10e
SPWAY.10d
SPWAY.10c
SPWAY.10b
SPWAY.10a
SPWAY.10
SPWAY.9c
SPWAY.9b
SPWAY.9a
SPWAY.9
SPWAY.8c
SPWAY.8b
SPWAY.8a
SPWAY.8
SPWAY.7c
SPWAY.7b
SPWAY.7a
SPWAY.7
SPWAY.6b
SPWAY.6a
SPWAY.6
SPWAY.5c
SPWAY.5b
SPWAY.5a
SPWAY.5
SPWAY.4c
SPWAY.4b
SPWAY.4a
SPWAY.4
SPWAY.3c
SPWAY.3b
SPWAY.3a
SPWAY.3
SPWAY.2d
SPWAY.2c
SPWAY.2b
SPWAY.2a
SPWAY.2
SPWAY.1c
SPWAY.1b
SPWAY.1a
SPWAY.1
HARNESS.16
HARNESS.15
HARNESS.14
SPF.30
SPF.29
SPF.28
11
10
9
PROCURE.8
PROCURE.7
PROCURE.6
PROCURE.5
PROCURE.4
PROCURE.3
PROCURE.2
PROCURE.1
HARNESS.12
HARNESS.11
HARNESS.10
HARNESS.9
HARNESS.8
HARNESS.7
HARNESS.6
HARNESS.5
HARNESS.4
HARNESS.3
HARNESS.2
HARNESS.1
AGT.87
AGT.86
AGT.85
AGT.84
AGT.83
AGT.81
AGT.80
AGT.79
AGT.78
AGT.77
AGT.76
AGT.75
AGT.74
AGT.73
AGT.72
AGT.71
AGT.70
AGT.69
AGT.68
AGT.67
AGT.66
AGT.65
AGT.64
AGT.63
AGT.62
AGT.61
AGT.60
AGT.59
AGT.58
AGT.57
OPS.14
AGT.56
AGT.55
AGT.54
AGT.53
AGT.52
AGT.51
AGT.50
AGT.49
AGT.48
AGT.47
AGT.46
AGT.45
AGT.44
AGT.43
AGT.42
AGT.41
AGT.40
AGT.39
AGT.38
AGT.37
AGT.36
AGT.35
AGT.34
AGT.33
AGT.32
AGT.31
AGT.30
AGT.29
AGT.28
AGT.27
AGT.26
AGT.25
AGT.24
AGT.23
AGT.22
AGT.21
AGT.20
AGT.19
AGT.18
AGT.17
AGT.16
AGT.15
AGT.14
AGT.13
AGT.12
AGT.11
AGT.10
AGT.9
AGT.8
AGT.7
AGT.6
AGT.5
AGT.4
AGT.3
AGT.2
AGT.1
TPL.13
TPL.12
TPL.11
TPL.10
TPL.9
TPL.8
TPL.7
TPL.6
TPL.5
TPL.4
TPL.3
TPL.2
TPL.1
CICD.9
CICD.8
CICD.7
CICD.6
CICD.5
CICD.4
CICD.3
CICD.2
CICD.1
OPS.13
OPS.12
OPS.11
OPS.10
OPS.9
OPS.8
OPS.7
OPS.6
OPS.5
OPS.4
OPS.3
OPS.2
OPS.1
CIT.14
CIT.13
CIT.12
CIT.11
CIT.10
CIT.9
CIT.8
CIT.7
CIT.6
CIT.5
CIT.4
CIT.3
CIT.2
CIT.1
EST.24
EST.23
EST.22
EST.21
EST.20
EST.18
EST.19
EST.17
EST.16
EST.15
EST.14
EST.13
EST.12
EST.11
EST.10
EST.9
EST.8
EST.7
EST.6
EST.5
EST.4
EST.3
EST.2
EST.1
SPF.27
SPF.26
SPF.25
SPF.24
SPF.23
SPF.22
SPF.21
SPF.20
SPF.19
SPF.18
SPF.17
SPF.16
SPF.15
SPF.14
SPF.13
SPF.12
SPF.11
SPF.10
SPF.9
SPF.8
SPF.7
SPF.6
SPF.5
SPF.4
SPF.3
SPF.2
SPF.1
8
7
6
5
4
3
2.1
2
1.1
1
V18.5b-carryover
V19.6
V19.5
V19.4
V19.3
V19.2
V19.1
V19.0
V18.5
V18.4
V18.2
V18.1
V17.5b-carryover
V18.6
V18.3
V18.0
V17.6
V17.3
V17.2
V17.5
V17.4
V17.1
V17.0
V16.5
V16.4
V16.2

Projects › Lists › ProjectTasks › Edit item